netdev - Re: [PATCH] staging: qlge: Fix indentation issue under long for loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1827050fdadb6173118fb396ad1fead23cda809f.camel@perches.com>
Date:   Sat, 09 Jul 2022 19:23:20 -0700
From:   Joe Perches <joe@...ches.com>
To:     Binyi Han <dantengknight@...il.com>,
        Manish Chopra <manishc@...vell.com>,
        GR-Linux-NIC-Dev@...vell.com, Coiby Xu <coiby.xu@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     netdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: qlge: Fix indentation issue under long for loop

On Sat, 2022-07-09 at 19:16 -0700, Binyi Han wrote:
> Fix indentation issue to adhere to Linux kernel coding style.
> Issue found by checkpatch.
> 
> Signed-off-by: Binyi Han <dantengknight@...il.com>
> ---
>  drivers/staging/qlge/qlge_main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
[]
> @@ -3009,8 +3009,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
>  
>  		for (page_entries = 0; page_entries <
>  			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)

Probably better to change the for loop to 3 lines as well.

		for (page_entries = 0;
		     page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN);
		     page_entries++)

> @@ -3024,8 +3024,8 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
>  
>  		for (page_entries = 0; page_entries <
>  			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++)
> -				base_indirect_ptr[page_entries] =
> -					cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));
> +			base_indirect_ptr[page_entries] =
> +				cpu_to_le64(tmp + (page_entries * DB_PAGE_SIZE));

etc...