lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <93dc367b01cdfbb68e6edf7367d2f69adfb5d407.camel@perches.com> Date: Mon, 11 Jul 2022 13:55:24 -0700 From: Joe Perches <joe@...ches.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Binyi Han <dantengknight@...il.com> Cc: Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com, Coiby Xu <coiby.xu@...il.com>, netdev@...r.kernel.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3] staging: qlge: Fix indentation issue under long for loop On Mon, 2022-07-11 at 10:05 +0200, Greg Kroah-Hartman wrote: > On Sun, Jul 10, 2022 at 02:04:18PM -0700, Binyi Han wrote: > > Fix indentation issue to adhere to Linux kernel coding style, > > Issue found by checkpatch. Change the long for loop into 3 lines. And > > optimize by avoiding the multiplication. > > > > Signed-off-by: Binyi Han <dantengknight@...il.com> > > --- > > v2: > > - Change the long for loop into 3 lines. > > v3: > > - Align page_entries in the for loop to open parenthesis. > > - Optimize by avoiding the multiplication. > > Please do not mix coding style fixes with "optimizations" or logical > changes. This should be multiple patches. > > Also, did you test this change on real hardware? At first glance, it's > not obvious that the code is still doing the same thing, so "proof" of > that would be nice to have. I read the code and suggested the optimization. It's the same logic.
Powered by blists - more mailing lists