netdev - Re: [patch net-next RFC 02/10] net: devlink: add unlocked variants of devling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ys1z5G2ZkHSe5eRo@shredder>
Date:   Tue, 12 Jul 2022 16:15:16 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, mlxsw@...dia.com,
        saeedm@...dia.com, moshe@...dia.com, tariqt@...dia.com
Subject: Re: [patch net-next RFC 02/10] net: devlink: add unlocked variants
 of devling_trap*() functions

In subject: s/devling/devlink/

On Tue, Jul 12, 2022 at 01:05:03PM +0200, Jiri Pirko wrote:
> From: Moshe Shemesh <moshe@...dia.com>
> 
> Add unlocked variants of devl_trap*() functions to be used in drivers
> called-in with devlink->lock held.
> 
> Signed-off-by: Moshe Shemesh <moshe@...dia.com>
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Please fold patch #6 into this. I guess the only reason for the
artificial split is that mlx5 does not use the functions from patch #6.

[...]

> +int devlink_traps_register(struct devlink *devlink,
> +			   const struct devlink_trap *traps,
> +			   size_t traps_count, void *priv)
> +{
> +	int ret;
> +
> +	devl_lock(devlink);
> +	ret = devl_traps_register(devlink, traps, traps_count, priv);

Most of the related code (including patch #6) uses 'err' instead of
'ret'

> +	devl_unlock(devlink);
> +
> +	return ret;
> +}