netdev - RE: [Patch v4 10/12] net: mana: Define max values for SGL entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jul 2022 18:56:19 +0000
From:   Long Li <longli@...rosoft.com>
To:     Dexuan Cui <decui@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "shiraz.saleem@...el.com" <shiraz.saleem@...el.com>,
        Ajay Sharma <sharmaajay@...rosoft.com>
CC:     "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [Patch v4 10/12] net: mana: Define max values for SGL entries

> Subject: RE: [Patch v4 10/12] net: mana: Define max values for SGL entries
> 
> > From: longli@...uxonhyperv.com <longli@...uxonhyperv.com>
> > Sent: Wednesday, June 15, 2022 7:07 PM ...
> > The number of maximum SGl entries should be computed from the maximum
> s/SGl/SGL
> 
> > @@ -436,6 +436,13 @@ struct gdma_wqe {  #define MAX_TX_WQE_SIZE 512
> > #define MAX_RX_WQE_SIZE 256
> >
> > +#define MAX_TX_WQE_SGL_ENTRIES	((GDMA_MAX_SQE_SIZE - \
> > +			sizeof(struct gdma_sge) - INLINE_OOB_SMALL_SIZE) / \
> > +			sizeof(struct gdma_sge))
> > +
> > +#define MAX_RX_WQE_SGL_ENTRIES	((GDMA_MAX_RQE_SIZE - \
> > +			sizeof(struct gdma_sge)) / sizeof(struct gdma_sge))
> 
> Can we make these '\' chars aligned? :-) Please refer to the definiton of
> "lock_requestor" in include/linux/hyperv.h.

Will fix this.

> 
> Reviewed-by: Dexuan Cui <decui@...rosoft.com>