netdev - Re: [PATCH net-next 1/9] net: marvell: prestera: Add router nexthops ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Jul 2022 20:22:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yevhen Orlov <yevhen.orlov@...ision.eu>
Cc:     netdev@...r.kernel.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <tchornyi@...vell.com>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/9] net: marvell: prestera: Add router
 nexthops ABI

On Sun, 10 Jul 2022 20:21:59 +0300 Yevhen Orlov wrote:
> @@ -591,6 +600,7 @@ void prestera_router_fini(struct prestera_switch *sw)
>  	unregister_fib_notifier(&init_net, &sw->router->fib_nb);
>  	unregister_inetaddr_notifier(&sw->router->inetaddr_nb);
>  	unregister_inetaddr_validator_notifier(&sw->router->inetaddr_valid_nb);
> +	kfree(sw->router->nhgrp_hw_state_cache);

Ah, you based it on top of the fix. We'll merge the fixes and -next on
Thursday so please wait until that happens. In the meantime you can
think of finding someone who could review the changes and speed things
up that way. You CCed a lot of Marvell and plvision people on these
but nobody from the community who actually works on routing offload...