netdev - Re: [PATCH net] sfc: fix use after free when disabling sriov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4ouf8whj4s5DxROOFpmPGCk92N+3iJh383n0ULP5he+pMYw@mail.gmail.com>
Date:   Tue, 12 Jul 2022 08:14:13 +0200
From:   Íñigo Huguet <ihuguet@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Edward Cree <ecree.xilinx@...il.com>,
        Martin Habets <habetsm.xilinx@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        Yanghang Liu <yanghliu@...hat.com>
Subject: Re: [PATCH net] sfc: fix use after free when disabling sriov

On Tue, Jul 12, 2022 at 5:39 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 11 Jul 2022 15:45:20 +0200 Íñigo Huguet wrote:
> > Use after free is detected by kfence when disabling sriov. What was read
> > after being freed was vf->pci_dev: it was freed from pci_disable_sriov
> > and later read in efx_ef10_sriov_free_vf_vports, called from
> > efx_ef10_sriov_free_vf_vswitching.
> >
> > Set the pointer to NULL at release time to not trying to read it later.
>
> Please add a Fixes tag and repost. Does ef100 need the same fix? :(
>

OK, will do. ef100 doesn't seem to need this, but I can't test because
I don't have any of these cards.

-- 
Íñigo Huguet