lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jul 2022 17:19:47 +0200 From: Dario Binacchi <dario.binacchi@...rulasolutions.com> To: linux-kernel@...r.kernel.org Cc: Richard Palethorpe <rpalethorpe@...e.de>, Jeroen Hofstee <jhofstee@...tronenergy.com>, Linux Memory Management List <linux-mm@...ck.org>, kernel test robot <oliver.sang@...el.com>, lkp@...el.com, lkp@...ts.01.org, ltp@...ts.linux.it, Dario Binacchi <dario.binacchi@...rulasolutions.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jakub Kicinski <kuba@...nel.org>, Jiri Slaby <jirislaby@...nel.org>, Marc Kleine-Budde <mkl@...gutronix.de>, Paolo Abeni <pabeni@...hat.com>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Vincent Mailhol <mailhol.vincent@...adoo.fr>, Wolfgang Grandegger <wg@...ndegger.com>, linux-can@...r.kernel.org, netdev@...r.kernel.org Subject: [PATCH] can: slcan: do not sleep with a spin lock held We can't call close_candev() with a spin lock held, so release the lock before calling it. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot <oliver.sang@...el.com> Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com> --- drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 54d29a410ad5..6aaf2986effc 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) /* TTY discipline is running. */ clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } + spin_unlock_bh(&sl->lock); netif_stop_queue(dev); close_candev(dev); sl->can.state = CAN_STATE_STOPPED; @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) sl->rcount = 0; sl->xleft = 0; - spin_unlock_bh(&sl->lock); return 0; } -- 2.32.0
Powered by blists - more mailing lists