netdev - Re: [PATCH net] sfc: fix kernel panic when creating VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a29124d2-3bf0-4bf1-a231-5937dfcf96b6@gmail.com>
Date:   Wed, 13 Jul 2022 16:51:58 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Íñigo Huguet <ihuguet@...hat.com>,
        habetsm.xilinx@...il.com, sshah@...arflare.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        Ma Yuying <yuma@...hat.com>
Subject: Re: [PATCH net] sfc: fix kernel panic when creating VF

On 13/07/2022 10:21, Íñigo Huguet wrote:
...> Fixes: d778819609a2 ("sfc: DMA the VF stats only when requested")
> Reported-by: Ma Yuying <yuma@...hat.com>
> Signed-off-by: Íñigo Huguet <ihuguet@...hat.com>

Acked-by: Edward Cree <ecree.xilinx@...il.com>

Really the whole locking thing around stats is ugly and we ought to
 redesign it so as to fix things properly (AFAICT there's no reason
 why the stats_lock needs to be taken by the caller rather than
 within the nic_type->update_stats() method), but for the time being
 this looks like the right minimal fix for 'net'.
-ed