netdev - Re: [PATCH net-next 1/1] ping: fix ipv6 ping socket flow labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ececa999-1e66-ecb8-972a-1dc2ba8d64fc@intel.com>
Date:   Wed, 13 Jul 2022 15:48:02 -0700
From:   Alan Brady <alan.brady@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        <netdev@...r.kernel.org>, <yoshfuji@...ux-ipv6.org>,
        <dsahern@...nel.org>, Gurucharan <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next 1/1] ping: fix ipv6 ping socket flow labels

On 7/13/2022 12:49 PM, Jakub Kicinski wrote:
> On Tue, 12 Jul 2022 09:56:08 -0700 Tony Nguyen wrote:
>> From: Alan Brady <alan.brady@...el.com>
>>
>> Ping sockets don't appear to make any attempt to preserve flow labels
>> created and set by userspace. Instead they are always clobbered by
>> autolabels (if enabled) or zero.
>>
>> This grabs the flowlabel out of the msghdr similar to how rawv6_sendmsg
>> does it and moves the memset up so we don't zero it.
>>
>> Signed-off-by: Alan Brady <alan.brady@...el.com>
>> Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at Intel)
>> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> 
> Thanks! Please add a selftest and s/fix/support/ in the subject
> otherwise  the stable ML bot will think this is a fix, and its more
> of a missing feature.

Gotcha, will do both, thanks!