netdev - Re: [PATCH net-next v2 3/3] selftests/net: Add sk_bind_sendto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2d28352a6c00db7c3b31d0b9aeca3ee5b196247.camel@redhat.com>
Date:   Thu, 14 Jul 2022 11:19:52 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Joanne Koong <joannelkoong@...il.com>, netdev@...r.kernel.org
Cc:     edumazet@...gle.com, kafai@...com, kuba@...nel.org,
        davem@...emloft.net
Subject: Re: [PATCH net-next v2 3/3] selftests/net: Add
 sk_bind_sendto_listen test

On Tue, 2022-07-12 at 16:53 -0700, Joanne Koong wrote:
> This patch adds a new test called sk_bind_sendto_listen.
> 
> This test exercises the path where a socket's rcv saddr changes after it
> has been added to the binding tables, and then a listen() on the socket
> is invoked. The listen() should succeed.
> 
> This test is copied over from one of syzbot's tests:
> https://syzkaller.appspot.com/x/repro.c?x=1673a38df00000
> 
> Signed-off-by: Joanne Koong <joannelkoong@...il.com>
> ---
>  tools/testing/selftests/net/.gitignore        |  1 +
>  tools/testing/selftests/net/Makefile          |  1 +
>  .../selftests/net/sk_bind_sendto_listen.c     | 80 +++++++++++++++++++
>  3 files changed, 82 insertions(+)
>  create mode 100644 tools/testing/selftests/net/sk_bind_sendto_listen.c
> 
> diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore
> index 5b1adf6e29ae..5fd74a1162cc 100644
> --- a/tools/testing/selftests/net/.gitignore
> +++ b/tools/testing/selftests/net/.gitignore
> @@ -39,3 +39,4 @@ toeplitz
>  cmsg_sender
>  unix_connect
>  bind_bhash
> +sk_bind_sendto_listen
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index e678fc3030a2..ffcc472d50d5 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -61,6 +61,7 @@ TEST_GEN_FILES += cmsg_sender
>  TEST_GEN_FILES += stress_reuseport_listen
>  TEST_PROGS += test_vxlan_vnifiltering.sh
>  TEST_GEN_FILES += bind_bhash
> +TEST_GEN_FILES += sk_bind_sendto_listen

It looks like this is never invoked by the self-tests ?!? you should
likely update bind_bhash.sh to run the new program.

Thanks!

Paolo