netdev - Re: [PATCH] p54: add missing parentheses in p54

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 14:58:48 +0200
From:   Arend Van Spriel <aspriel@...il.com>
To:     Johannes Berg <johannes@...solutions.net>,
        Rustam Subkhankulov <subkhankulov@...ras.ru>,
        Christian Lamparter <chunkeey@...glemail.com>
Cc:     Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] p54: add missing parentheses in p54_flush()

On 7/14/2022 11:45 AM, Johannes Berg wrote:
> On Thu, 2022-07-14 at 12:17 +0300, Rustam Subkhankulov wrote:
>> The assignment of the value to the variable total in the loop
>> condition must be enclosed in additional parentheses, since otherwise,
>> in accordance with the precedence of the operators, the conjunction
>> will be performed first, and only then the assignment.
>>
>> Due to this error, a warning later in the function after the loop may
>> not occur in the situation when it should.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Signed-off-by: Rustam Subkhankulov <subkhankulov@...ras.ru>
>> Fixes: d3466830c165 ("p54: move under intersil vendor directory")
>>
> 
> That fixes can't be right, it just moved the code.

commit 0d4171e2153b70957fe67867420a1a24d5e4cd82
Author: Christian Lamparter <chunkeey@...glemail.com>
Date:   Wed Feb 16 19:43:06 2011 +0100

     p54: implement flush callback

     Signed-off-by: Christian Lamparter <chunkeey@...glemail.com>
     Signed-off-by: John W. Linville <linville@...driver.com>