netdev - Re: [PATCH] ipv6: fix lockdep splat in in6_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 17:46:18 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        eric.dumazet@...il.com, syzbot <syzkaller@...glegroups.com>,
        Taehee Yoo <ap420073@...il.com>,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Subject: Re: [PATCH] ipv6: fix lockdep splat in in6_dump_addrs()

On Tue, Jun 28, 2022 at 12:12:48PM +0000, Eric Dumazet wrote:
> As reported by syzbot, we should not use rcu_dereference()
> when rcu_read_lock() is not held.
> 

Is the comment at the top of the function out of date?

  5141  /* called with rcu_read_lock() */
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^

  5142  static int in6_dump_addrs(struct inet6_dev *idev, struct sk_buff *skb,
  5143                            struct netlink_callback *cb, int s_ip_idx,
  5144                            struct inet6_fill_args *fillargs)
  5145  {

regards,
dan carpenter