netdev - Re: [PATCH net 4/7] iavf: Fix NULL pointer dereference in iavf_get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f29588a-6c4c-2e0f-8392-71f87e07958a@intel.com>
Date:   Thu, 14 Jul 2022 09:18:56 -0700
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        Przemyslaw Patynowski <przemyslawx.patynowski@...el.com>,
        <netdev@...r.kernel.org>,
        Mateusz Palczewski <mateusz.palczewski@...el.com>,
        Marek Szlosek <marek.szlosek@...el.com>
Subject: Re: [PATCH net 4/7] iavf: Fix NULL pointer dereference in
 iavf_get_link_ksettings



On 7/12/2022 6:26 PM, Jakub Kicinski wrote:
> On Mon, 11 Jul 2022 16:02:40 -0700 Tony Nguyen wrote:
>> +	/* if VF failed initialization during __IAVF_INIT_GET_RESOURCES,
>> +	 * it is possible for this variable to be freed there.
>> +	 */
>> +	if (!adapter->vf_res)
>> +		return -EAGAIN;
> 
> I think I already rejected a similar patch in the past.
> 
> ethtool APIs should not return -EAGAIN, if the driver needs to wait
> for some init or reset to finish -- it should just wait, we can't
> throw errors at user space and hope it will retry.

I talked to the author and he doesn't believe waiting in this case would 
help; he is looking to see if there are other alternatives.

Thanks,
Tony