netdev - [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220715171755.38497-1-kuniyu@amazon.com>
Date:   Fri, 15 Jul 2022 10:17:40 -0700
From:   Kuniyuki Iwashima <kuniyu@...zon.com>
To:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>
CC:     Kuniyuki Iwashima <kuniyu@...zon.com>,
        Kuniyuki Iwashima <kuni1840@...il.com>,
        <netdev@...r.kernel.org>
Subject: [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 3).

This series fixes data-races around 21 knobs after
igmp_link_local_mcast_reports in ipv4_net_table.

These 4 knobs are skipped because they are safe.

  - tcp_congestion_control: Safe with RCU and xchg().
  - tcp_available_congestion_control: Read only.
  - tcp_allowed_congestion_control: Safe with RCU and spinlock().
  - tcp_fastopen_key: Safe with RCU and xchg()

So, round 4 will start with fib_multipath_use_neigh.

Kuniyuki Iwashima (15):
  igmp: Fix data-races around sysctl_igmp_llm_reports.
  igmp: Fix a data-race around sysctl_igmp_max_memberships.
  igmp: Fix data-races around sysctl_igmp_max_msf.
  igmp: Fix data-races around sysctl_igmp_qrv.
  tcp: Fix data-races around keepalive sysctl knobs.
  tcp: Fix data-races around sysctl_tcp_syn(ack)?_retries.
  tcp: Fix data-races around sysctl_tcp_syncookies.
  tcp: Fix data-races around sysctl_tcp_migrate_req.
  tcp: Fix data-races around sysctl_tcp_reordering.
  tcp: Fix data-races around some timeout sysctl knobs.
  tcp: Fix a data-race around sysctl_tcp_notsent_lowat.
  tcp: Fix a data-race around sysctl_tcp_tw_reuse.
  tcp: Fix data-races around sysctl_max_syn_backlog.
  tcp: Fix data-races around sysctl_tcp_fastopen.
  tcp: Fix data-races around sysctl_tcp_fastopen_blackhole_timeout.

 drivers/net/amt.c               |  4 +--
 include/net/tcp.h               | 14 ++++++----
 net/core/filter.c               |  4 +--
 net/core/sock_reuseport.c       |  4 +--
 net/ipv4/af_inet.c              |  2 +-
 net/ipv4/igmp.c                 | 49 +++++++++++++++++++--------------
 net/ipv4/inet_connection_sock.c |  3 +-
 net/ipv4/ip_sockglue.c          |  6 ++--
 net/ipv4/syncookies.c           |  3 +-
 net/ipv4/tcp.c                  | 13 +++++----
 net/ipv4/tcp_fastopen.c         |  9 +++---
 net/ipv4/tcp_input.c            | 36 +++++++++++++++---------
 net/ipv4/tcp_ipv4.c             |  2 +-
 net/ipv4/tcp_metrics.c          |  3 +-
 net/ipv4/tcp_output.c           |  2 +-
 net/ipv4/tcp_timer.c            | 20 ++++++++------
 net/ipv6/syncookies.c           |  3 +-
 net/smc/smc_llc.c               |  2 +-
 18 files changed, 106 insertions(+), 73 deletions(-)

-- 
2.30.2