netdev - Re: [net-next: PATCH v2 1/8] net: phy: fixed_phy: switch to fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPv3WKcSNrYiABLzHrYsL1gx9vZZ6ja2ZQiOj1hGTKzDmOKYAQ@mail.gmail.com>
Date:   Fri, 15 Jul 2022 21:10:37 +0200
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Grzegorz Bernacki <gjb@...ihalf.com>,
        Grzegorz Jaszczyk <jaz@...ihalf.com>,
        Tomasz Nowicki <tn@...ihalf.com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@....com>,
        upstream@...ihalf.com
Subject: Re: [net-next: PATCH v2 1/8] net: phy: fixed_phy: switch to fwnode_ API

pt., 15 lip 2022 o 19:21 Florian Fainelli <f.fainelli@...il.com> napisał(a):
>
> On 7/15/22 01:50, Marcin Wojtas wrote:
> > This patch allows to use fixed_phy driver and its helper
> > functions without Device Tree dependency, by swtiching from
> > of_ to fwnode_ API.
> >
> > Signed-off-by: Marcin Wojtas <mw@...ihalf.com>
> > ---
> >  include/linux/phy_fixed.h   |  4 +-
> >  drivers/net/mdio/of_mdio.c  |  2 +-
> >  drivers/net/phy/fixed_phy.c | 39 +++++++-------------
> >  3 files changed, 17 insertions(+), 28 deletions(-)
> >
> > diff --git a/include/linux/phy_fixed.h b/include/linux/phy_fixed.h
> > index 52bc8e487ef7..449a927231ec 100644
> > --- a/include/linux/phy_fixed.h
> > +++ b/include/linux/phy_fixed.h
> > @@ -19,7 +19,7 @@ extern int fixed_phy_add(unsigned int irq, int phy_id,
> >                        struct fixed_phy_status *status);
> >  extern struct phy_device *fixed_phy_register(unsigned int irq,
> >                                            struct fixed_phy_status *status,
> > -                                          struct device_node *np);
> > +                                          struct fwnode_handle *fwnode);
>
> I think this ought to require a forward declaration of struct fwnode_handle and a removal of the forward declaration of device_node.
>

Ok, I'll replace the declaration.

> With that fixes:
>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>

Thanks,
Marcin