lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list] 
Date:   Sun, 17 Jul 2022 05:27:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sean Anderson <sean.anderson@...o.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Madalin Bucur <madalin.bucur@....com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        linux-arm-kernel@...ts.infradead.org,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org,
        Sean Anderson <sean.anderson@...o.com>
Subject: Re: [PATCH net-next v3 41/47] [RFT] net: dpaa: Convert to phylink

Hi Sean,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/net-dpaa-Convert-to-phylink/20220717-002036
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2acd1022549e210edc4cfc9fc65b07b88751f0d9
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220717/202207170518.RygxqhFI-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4411e66d2bb3fe21094f63ed67d2c2ebce69eaee
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sean-Anderson/net-dpaa-Convert-to-phylink/20220717-002036
        git checkout 4411e66d2bb3fe21094f63ed67d2c2ebce69eaee
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/ethernet/freescale/fman/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/freescale/fman/fman_dtsec.c: In function 'init.constprop':
>> drivers/net/ethernet/freescale/fman/fman_dtsec.c:368:21: warning: 'tmp' is used uninitialized [-Wuninitialized]
     368 |                 tmp |= cfg->tx_pause_time;
         |                 ~~~~^~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/freescale/fman/fman_dtsec.c:360:13: note: 'tmp' was declared here
     360 |         u32 tmp;
         |             ^~~


vim +/tmp +368 drivers/net/ethernet/freescale/fman/fman_dtsec.c

6b995bdefc10b4 Madalin Bucur  2020-03-05  354  
57ba4c9b56d898 Igal Liberman  2015-12-21  355  static int init(struct dtsec_regs __iomem *regs, struct dtsec_cfg *cfg,
6b995bdefc10b4 Madalin Bucur  2020-03-05  356  		phy_interface_t iface, u16 iface_speed, u64 addr,
57ba4c9b56d898 Igal Liberman  2015-12-21  357  		u32 exception_mask, u8 tbi_addr)
57ba4c9b56d898 Igal Liberman  2015-12-21  358  {
6b995bdefc10b4 Madalin Bucur  2020-03-05  359  	enet_addr_t eth_addr;
57ba4c9b56d898 Igal Liberman  2015-12-21  360  	u32 tmp;
6b995bdefc10b4 Madalin Bucur  2020-03-05  361  	int i;
57ba4c9b56d898 Igal Liberman  2015-12-21  362  
57ba4c9b56d898 Igal Liberman  2015-12-21  363  	/* Soft reset */
57ba4c9b56d898 Igal Liberman  2015-12-21  364  	iowrite32be(MACCFG1_SOFT_RESET, &regs->maccfg1);
57ba4c9b56d898 Igal Liberman  2015-12-21  365  	iowrite32be(0, &regs->maccfg1);
57ba4c9b56d898 Igal Liberman  2015-12-21  366  
57ba4c9b56d898 Igal Liberman  2015-12-21  367  	if (cfg->tx_pause_time)
57ba4c9b56d898 Igal Liberman  2015-12-21 @368  		tmp |= cfg->tx_pause_time;
57ba4c9b56d898 Igal Liberman  2015-12-21  369  	if (cfg->tx_pause_time_extd)
57ba4c9b56d898 Igal Liberman  2015-12-21  370  		tmp |= cfg->tx_pause_time_extd << PTV_PTE_SHIFT;
57ba4c9b56d898 Igal Liberman  2015-12-21  371  	iowrite32be(tmp, &regs->ptv);
57ba4c9b56d898 Igal Liberman  2015-12-21  372  
57ba4c9b56d898 Igal Liberman  2015-12-21  373  	tmp = 0;
57ba4c9b56d898 Igal Liberman  2015-12-21  374  	tmp |= (cfg->rx_prepend << RCTRL_PAL_SHIFT) & RCTRL_PAL_MASK;
57ba4c9b56d898 Igal Liberman  2015-12-21  375  	/* Accept short frames */
57ba4c9b56d898 Igal Liberman  2015-12-21  376  	tmp |= RCTRL_RSF;
57ba4c9b56d898 Igal Liberman  2015-12-21  377  
57ba4c9b56d898 Igal Liberman  2015-12-21  378  	iowrite32be(tmp, &regs->rctrl);
57ba4c9b56d898 Igal Liberman  2015-12-21  379  
57ba4c9b56d898 Igal Liberman  2015-12-21  380  	/* Assign a Phy Address to the TBI (TBIPA).
57ba4c9b56d898 Igal Liberman  2015-12-21  381  	 * Done also in cases where TBI is not selected to avoid conflict with
57ba4c9b56d898 Igal Liberman  2015-12-21  382  	 * the external PHY's Physical address
57ba4c9b56d898 Igal Liberman  2015-12-21  383  	 */
57ba4c9b56d898 Igal Liberman  2015-12-21  384  	iowrite32be(tbi_addr, &regs->tbipa);
57ba4c9b56d898 Igal Liberman  2015-12-21  385  
57ba4c9b56d898 Igal Liberman  2015-12-21  386  	iowrite32be(0, &regs->tmr_ctrl);
57ba4c9b56d898 Igal Liberman  2015-12-21  387  
57ba4c9b56d898 Igal Liberman  2015-12-21  388  	if (cfg->ptp_tsu_en) {
57ba4c9b56d898 Igal Liberman  2015-12-21  389  		tmp = 0;
57ba4c9b56d898 Igal Liberman  2015-12-21  390  		tmp |= TMR_PEVENT_TSRE;
57ba4c9b56d898 Igal Liberman  2015-12-21  391  		iowrite32be(tmp, &regs->tmr_pevent);
57ba4c9b56d898 Igal Liberman  2015-12-21  392  
57ba4c9b56d898 Igal Liberman  2015-12-21  393  		if (cfg->ptp_exception_en) {
57ba4c9b56d898 Igal Liberman  2015-12-21  394  			tmp = 0;
57ba4c9b56d898 Igal Liberman  2015-12-21  395  			tmp |= TMR_PEMASK_TSREEN;
57ba4c9b56d898 Igal Liberman  2015-12-21  396  			iowrite32be(tmp, &regs->tmr_pemask);
57ba4c9b56d898 Igal Liberman  2015-12-21  397  		}
57ba4c9b56d898 Igal Liberman  2015-12-21  398  	}
57ba4c9b56d898 Igal Liberman  2015-12-21  399  
57ba4c9b56d898 Igal Liberman  2015-12-21  400  	tmp = 0;
57ba4c9b56d898 Igal Liberman  2015-12-21  401  	tmp |= MACCFG1_RX_FLOW;
57ba4c9b56d898 Igal Liberman  2015-12-21  402  	tmp |= MACCFG1_TX_FLOW;
57ba4c9b56d898 Igal Liberman  2015-12-21  403  	iowrite32be(tmp, &regs->maccfg1);
57ba4c9b56d898 Igal Liberman  2015-12-21  404  
57ba4c9b56d898 Igal Liberman  2015-12-21  405  	tmp = 0;
57ba4c9b56d898 Igal Liberman  2015-12-21  406  
57ba4c9b56d898 Igal Liberman  2015-12-21  407  	tmp |= (cfg->preamble_len << MACCFG2_PREAMBLE_LENGTH_SHIFT) &
57ba4c9b56d898 Igal Liberman  2015-12-21  408  		MACCFG2_PREAMBLE_LENGTH_MASK;
57ba4c9b56d898 Igal Liberman  2015-12-21  409  	if (cfg->tx_pad_crc)
57ba4c9b56d898 Igal Liberman  2015-12-21  410  		tmp |= MACCFG2_PAD_CRC_EN;
57ba4c9b56d898 Igal Liberman  2015-12-21  411  	iowrite32be(tmp, &regs->maccfg2);
57ba4c9b56d898 Igal Liberman  2015-12-21  412  
57ba4c9b56d898 Igal Liberman  2015-12-21  413  	tmp = (((cfg->non_back_to_back_ipg1 <<
57ba4c9b56d898 Igal Liberman  2015-12-21  414  		 IPGIFG_NON_BACK_TO_BACK_IPG_1_SHIFT)
57ba4c9b56d898 Igal Liberman  2015-12-21  415  		& IPGIFG_NON_BACK_TO_BACK_IPG_1)
57ba4c9b56d898 Igal Liberman  2015-12-21  416  	       | ((cfg->non_back_to_back_ipg2 <<
57ba4c9b56d898 Igal Liberman  2015-12-21  417  		   IPGIFG_NON_BACK_TO_BACK_IPG_2_SHIFT)
57ba4c9b56d898 Igal Liberman  2015-12-21  418  		 & IPGIFG_NON_BACK_TO_BACK_IPG_2)
57ba4c9b56d898 Igal Liberman  2015-12-21  419  	       | ((cfg->min_ifg_enforcement << IPGIFG_MIN_IFG_ENFORCEMENT_SHIFT)
57ba4c9b56d898 Igal Liberman  2015-12-21  420  		 & IPGIFG_MIN_IFG_ENFORCEMENT)
57ba4c9b56d898 Igal Liberman  2015-12-21  421  	       | (cfg->back_to_back_ipg & IPGIFG_BACK_TO_BACK_IPG));
57ba4c9b56d898 Igal Liberman  2015-12-21  422  	iowrite32be(tmp, &regs->ipgifg);
57ba4c9b56d898 Igal Liberman  2015-12-21  423  
57ba4c9b56d898 Igal Liberman  2015-12-21  424  	tmp = 0;
57ba4c9b56d898 Igal Liberman  2015-12-21  425  	tmp |= HAFDUP_EXCESS_DEFER;
57ba4c9b56d898 Igal Liberman  2015-12-21  426  	tmp |= ((cfg->halfdup_retransmit << HAFDUP_RETRANSMISSION_MAX_SHIFT)
57ba4c9b56d898 Igal Liberman  2015-12-21  427  		& HAFDUP_RETRANSMISSION_MAX);
57ba4c9b56d898 Igal Liberman  2015-12-21  428  	tmp |= (cfg->halfdup_coll_window & HAFDUP_COLLISION_WINDOW);
57ba4c9b56d898 Igal Liberman  2015-12-21  429  
57ba4c9b56d898 Igal Liberman  2015-12-21  430  	iowrite32be(tmp, &regs->hafdup);
57ba4c9b56d898 Igal Liberman  2015-12-21  431  
57ba4c9b56d898 Igal Liberman  2015-12-21  432  	/* Initialize Maximum frame length */
57ba4c9b56d898 Igal Liberman  2015-12-21  433  	iowrite32be(cfg->maximum_frame, &regs->maxfrm);
57ba4c9b56d898 Igal Liberman  2015-12-21  434  
57ba4c9b56d898 Igal Liberman  2015-12-21  435  	iowrite32be(0xffffffff, &regs->cam1);
57ba4c9b56d898 Igal Liberman  2015-12-21  436  	iowrite32be(0xffffffff, &regs->cam2);
57ba4c9b56d898 Igal Liberman  2015-12-21  437  
57ba4c9b56d898 Igal Liberman  2015-12-21  438  	iowrite32be(exception_mask, &regs->imask);
57ba4c9b56d898 Igal Liberman  2015-12-21  439  
57ba4c9b56d898 Igal Liberman  2015-12-21  440  	iowrite32be(0xffffffff, &regs->ievent);
57ba4c9b56d898 Igal Liberman  2015-12-21  441  
f3353b99022583 Madalin Bucur  2020-03-05  442  	if (addr) {
6b995bdefc10b4 Madalin Bucur  2020-03-05  443  		MAKE_ENET_ADDR_FROM_UINT64(addr, eth_addr);
766607570becbd Jakub Kicinski 2021-10-14  444  		set_mac_address(regs, (const u8 *)eth_addr);
f3353b99022583 Madalin Bucur  2020-03-05  445  	}
57ba4c9b56d898 Igal Liberman  2015-12-21  446  
57ba4c9b56d898 Igal Liberman  2015-12-21  447  	/* HASH */
57ba4c9b56d898 Igal Liberman  2015-12-21  448  	for (i = 0; i < NUM_OF_HASH_REGS; i++) {
57ba4c9b56d898 Igal Liberman  2015-12-21  449  		/* Initialize IADDRx */
57ba4c9b56d898 Igal Liberman  2015-12-21  450  		iowrite32be(0, &regs->igaddr[i]);
57ba4c9b56d898 Igal Liberman  2015-12-21  451  		/* Initialize GADDRx */
57ba4c9b56d898 Igal Liberman  2015-12-21  452  		iowrite32be(0, &regs->gaddr[i]);
57ba4c9b56d898 Igal Liberman  2015-12-21  453  	}
57ba4c9b56d898 Igal Liberman  2015-12-21  454  
57ba4c9b56d898 Igal Liberman  2015-12-21  455  	return 0;
57ba4c9b56d898 Igal Liberman  2015-12-21  456  }
57ba4c9b56d898 Igal Liberman  2015-12-21  457  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists