lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <81f3eeda-0888-2869-659e-dc38c0a9debf@I-love.SAKURA.ne.jp> Date: Sun, 17 Jul 2022 11:32:38 +0900 From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> To: Johannes Berg <johannes@...solutions.net>, Toke Høiland-Jørgensen <toke@...nel.org>, Felix Fietkau <nbd@....name> Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: [PATCH] wifi: mac80211: initialize fq.lock as early as possible lockdep complains use of uninitialized spinlock at ieee80211_do_stop() [1], for commit f856373e2f31ffd3 ("wifi: mac80211: do not wake queues on a vif that is being stopped") guards clear_bit() using fq.lock even before fq_init() from ieee80211_txq_setup_flows() initializes this spinlock. Initialize this spinlock as early as possible. Link: https://syzkaller.appspot.com/bug?extid=eceab52db7c4b961e9d6 [1] Reported-by: syzbot <syzbot+eceab52db7c4b961e9d6@...kaller.appspotmail.com> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> Fixes: f856373e2f31ffd3 ("wifi: mac80211: do not wake queues on a vif that is being stopped") Tested-by: syzbot <syzbot+eceab52db7c4b961e9d6@...kaller.appspotmail.com> --- net/mac80211/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac80211/main.c b/net/mac80211/main.c index 5a385d4146b9..584e98300bbf 100644 --- a/net/mac80211/main.c +++ b/net/mac80211/main.c @@ -642,6 +642,7 @@ struct ieee80211_hw *ieee80211_alloc_hw_nm(size_t priv_data_len, wiphy->bss_priv_size = sizeof(struct ieee80211_bss); local = wiphy_priv(wiphy); + spin_lock_init(&local->fq.lock); if (sta_info_init(local)) goto err_free; -- 2.18.4
Powered by blists - more mailing lists