lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220717111523.GA3118@localhost.localdomain> Date: Sun, 17 Jul 2022 13:15:23 +0200 From: Guillaume Nault <gnault@...hat.com> To: "Drewek, Wojciech" <wojciech.drewek@...el.com> Cc: Marcin Szycik <marcin.szycik@...ux.intel.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "davem@...emloft.net" <davem@...emloft.net>, "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "gustavoars@...nel.org" <gustavoars@...nel.org>, "baowen.zheng@...igine.com" <baowen.zheng@...igine.com>, "boris.sukholitko@...adcom.com" <boris.sukholitko@...adcom.com>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "jhs@...atatu.com" <jhs@...atatu.com>, "jiri@...nulli.us" <jiri@...nulli.us>, "kurt@...utronix.de" <kurt@...utronix.de>, "pablo@...filter.org" <pablo@...filter.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "paulb@...dia.com" <paulb@...dia.com>, "simon.horman@...igine.com" <simon.horman@...igine.com>, "komachi.yoshiki@...il.com" <komachi.yoshiki@...il.com>, "zhangkaiheb@....com" <zhangkaiheb@....com>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "michal.swiatkowski@...ux.intel.com" <michal.swiatkowski@...ux.intel.com>, "Lobakin, Alexandr" <alexandr.lobakin@...el.com>, "mostrows@...thlink.net" <mostrows@...thlink.net>, "paulus@...ba.org" <paulus@...ba.org> Subject: Re: [RFC PATCH net-next v4 1/4] flow_dissector: Add PPPoE dissectors On Wed, Jul 13, 2022 at 01:54:35PM +0000, Drewek, Wojciech wrote: > I think this should work with both LE and BE arch, what do you think Guillaume? > We don't want to spam so much with next versions so maybe it is better > to ask earlier. > > u16 ppp_proto; > > ppp_proto = ntohs(hdr->proto); > if (ppp_proto & 256) { > ppp_proto = htons(ppp_proto >> 8); > nhoff += PPPOE_SES_HLEN - 1; > } else { > ppp_proto = htons(ppp_proto); > nhoff += PPPOE_SES_HLEN; > } Sorry for responding late. I was away this week (and will be next week too) and have very sporadic (and slow) Internet connection and limitted time for review. I saw you've sent a v5 with this code, I'll reply there. Thanks for being so patient.
Powered by blists - more mailing lists