netdev - Re: [RFC PATCH net-next v3] net: virtio_net: notifications coalescing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJs=3_DbPS9LpDFavP867udnDgRUywDBLJyxZYX1ZbfGmLrQTQ@mail.gmail.com>
Date:   Sun, 17 Jul 2022 18:00:36 +0300
From:   Alvaro Karsz <alvaro.karsz@...id-run.com>
To:     Dave Taht <dave.taht@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RFC PATCH net-next v3] net: virtio_net: notifications coalescing support

Hi Dave,

> What are a typical range of settings for these?

This entirely depends on the user, and the values are set using ethtool.
$  ethtool -C <interface>  tx-frames X rx-frames Y rx-usecs Z tx-usecs W

> Bytes = time.  Packets nowadays have a dynamic range of 64-64k bytes,
> and with big TCP even more. would there be any way to use
> bytes rather than packets?

This feature should follow the VirtIO spec.
The parameters are set with ethtool, so we should use the defined
ethtool parameters.

The parameters are set with the virtnet_set_coalesce function, which
is the ethtool_ops set_coalesce callback.