netdev - Re: [PATCH] vmxnet3: Implement ethtool's get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202207172303.yyCkQKVF-lkp@intel.com>
Date:   Mon, 18 Jul 2022 00:03:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andrey Turkin <andrey.turkin@...il.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Ronak Doshi <doshir@...are.com>,
        VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
        Andrey Turkin <andrey.turkin@...il.com>
Subject: Re: [PATCH] vmxnet3: Implement ethtool's get_channels command

Hi Andrey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 972a278fe60c361eb8f37619f562f092e8786d7c]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrey-Turkin/vmxnet3-Implement-ethtool-s-get_channels-command/20220717-102410
base:   972a278fe60c361eb8f37619f562f092e8786d7c
config: i386-randconfig-a015-20211103 (https://download.01.org/0day-ci/archive/20220717/202207172303.yyCkQKVF-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/87d4e00b53b145b85dfcda9645ed4a2467caab7d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andrey-Turkin/vmxnet3-Implement-ethtool-s-get_channels-command/20220717-102410
        git checkout 87d4e00b53b145b85dfcda9645ed4a2467caab7d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/vmxnet3/vmxnet3_ethtool.c:1191:6: warning: no previous prototype for 'vmxnet3_get_channels' [-Wmissing-prototypes]
    1191 | void vmxnet3_get_channels(struct net_device *netdev,
         |      ^~~~~~~~~~~~~~~~~~~~
   drivers/net/vmxnet3/vmxnet3_ethtool.c: In function 'vmxnet3_get_channels':
>> drivers/net/vmxnet3/vmxnet3_ethtool.c:1194:33: warning: unused variable 'adapter' [-Wunused-variable]
    1194 |         struct vmxnet3_adapter *adapter = netdev_priv(netdev);
         |                                 ^~~~~~~


vim +/adapter +1194 drivers/net/vmxnet3/vmxnet3_ethtool.c

  1190	
  1191	void vmxnet3_get_channels(struct net_device *netdev,
  1192				  struct ethtool_channels *ec)
  1193	{
> 1194		struct vmxnet3_adapter *adapter = netdev_priv(netdev);
  1195	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp