lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8d99d06a-adfb-5976-4dbc-11fcfbcab7ae@gmail.com> Date: Sun, 17 Jul 2022 09:56:47 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Vivien Didelot <vivien.didelot@...il.com> Subject: Re: [PATCH net 01/15] docs: net: dsa: update probing documentation On 7/17/2022 8:14 AM, Andrew Lunn wrote: > Hi Vladimir > >> +Switch registration from the perspective of a driver means passing a valid >> +``struct dsa_switch`` pointer to ``dsa_register_switch()``, usually from the >> +switch driver's probing function. The following members must be valid in the >> +provided structure: > >> + >> +- ``ds->priv``: backpointer to a driver-private data structure which can be >> + retrieved in all further DSA method callbacks. > > I'm not sure this is strictly true. The DSA core itself should not use > ds->priv. And the driver could use other means, like > dev_get_platdata(ds->dev->pdev) to get at is private data. But in > practice it is true. The former is a tad more compact and "usual" when DSA already provides a driver model IMHO. -- Florian
Powered by blists - more mailing lists