netdev - Re: [PATCH iproute2] uapi: add vdpa.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Jul 2022 13:18:28 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Parav Pandit <parav@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] uapi: add vdpa.h

On Mon, 18 Jul 2022 11:51:09 -0600
David Ahern <dsahern@...il.com> wrote:

> On 7/18/22 10:55 AM, Stephen Hemminger wrote:
> > On Mon, 18 Jul 2022 16:40:30 +0000
> > Parav Pandit <parav@...dia.com> wrote:
> >   
> >> We kept this in vdpa/include/uapi/linux/vdpa.h after inputs from David.
> >> This is because vdpa was following rdma style sync with the kernel headers.
> >> Rdma subsystem kernel header is in rdma/include/uapi/rdma/rdma_netlink.h.
> >>
> >> Any reason to take different route for vdpa?
> >> If so, duplicate file from vdpa/include/uapi/linux/vdpa.h should be removed.
> >> So that there is only one vdpa.h file.
> >>
> >> If so, should we move rdma files also similarly?
> >>
> >> Similar discussion came up in the past. (don't have ready reference to the discussion).
> >> And David's input was to keep the way it is like rdma.  
> > 
> > RDMA is different and contained to one directory.
> > VDPA is picking up things from linux/.
> > And the current version is not kept up to date with kernel headers.
> > Fixing that now.  
> 
> Updates to vdpa.h do not go through net-next so moving it to
> include/uapi/linux can cause problems when trying to sync headers to
> net-next commits. That's why it was put under vpda, similar to the rdma
> model.

Ok, will make sure the update script for current picks it up correctly.