netdev - Re: [v2] wifi: p54: add missing parentheses in p54

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <165814529503.17539.8245171776508092662.kvalo@kernel.org>
Date:   Mon, 18 Jul 2022 11:54:56 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Rustam Subkhankulov <subkhankulov@...ras.ru>
Cc:     Christian Lamparter <chunkeey@...glemail.com>,
        Rustam Subkhankulov <subkhankulov@...ras.ru>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        ldv-project@...uxtesting.org
Subject: Re: [v2] wifi: p54: add missing parentheses in p54_flush()

Rustam Subkhankulov <subkhankulov@...ras.ru> wrote:

> The assignment of the value to the variable total in the loop
> condition must be enclosed in additional parentheses, since otherwise,
> in accordance with the precedence of the operators, the conjunction
> will be performed first, and only then the assignment.
> 
> Due to this error, a warning later in the function after the loop may
> not occur in the situation when it should.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Rustam Subkhankulov <subkhankulov@...ras.ru>
> Fixes: 0d4171e2153b ("p54: implement flush callback")
> Acked-by: Christian Lamparter <chunkeey@...il.com>

Patch applied to wireless-next.git, thanks.

bcfd9d7f6840 wifi: p54: add missing parentheses in p54_flush()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220714134831.106004-1-subkhankulov@ispras.ru/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches