lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 18 Jul 2022 11:54:56 +0000 (UTC)
From:   Kalle Valo <>
To:     Rustam Subkhankulov <>
Cc:     Christian Lamparter <>,
        Rustam Subkhankulov <>,
        "David S. Miller" <>,
        Eric Dumazet <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,,,,
        Alexey Khoroshilov <>,
Subject: Re: [v2] wifi: p54: add missing parentheses in p54_flush()

Rustam Subkhankulov <> wrote:

> The assignment of the value to the variable total in the loop
> condition must be enclosed in additional parentheses, since otherwise,
> in accordance with the precedence of the operators, the conjunction
> will be performed first, and only then the assignment.
> Due to this error, a warning later in the function after the loop may
> not occur in the situation when it should.
> Found by Linux Verification Center ( with SVACE.
> Signed-off-by: Rustam Subkhankulov <>
> Fixes: 0d4171e2153b ("p54: implement flush callback")
> Acked-by: Christian Lamparter <>

Patch applied to wireless-next.git, thanks.

bcfd9d7f6840 wifi: p54: add missing parentheses in p54_flush()


Powered by blists - more mailing lists