lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Jul 2022 12:01:21 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> Cc: Johannes Berg <johannes@...solutions.net>, Toke Høiland-Jørgensen <toke@...nel.org>, Felix Fietkau <nbd@....name>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH v2] wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop() Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> wrote: > lockdep complains use of uninitialized spinlock at ieee80211_do_stop() [1], > for commit f856373e2f31ffd3 ("wifi: mac80211: do not wake queues on a vif > that is being stopped") guards clear_bit() using fq.lock even before > fq_init() from ieee80211_txq_setup_flows() initializes this spinlock. > > According to discussion [2], Toke was not happy with expanding usage of > fq.lock. Since __ieee80211_wake_txqs() is called under RCU read lock, we > can instead use synchronize_rcu() for flushing ieee80211_wake_txqs(). > > Link: https://syzkaller.appspot.com/bug?extid=eceab52db7c4b961e9d6 [1] > Link: https://lkml.kernel.org/r/874k0zowh2.fsf@toke.dk [2] > Reported-by: syzbot <syzbot+eceab52db7c4b961e9d6@...kaller.appspotmail.com> > Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> > Fixes: f856373e2f31ffd3 ("wifi: mac80211: do not wake queues on a vif that is being stopped") > Tested-by: syzbot <syzbot+eceab52db7c4b961e9d6@...kaller.appspotmail.com> > Acked-by: Toke Høiland-Jørgensen <toke@...nel.org> Patch applied to wireless-next.git, thanks. 3598cb6e1862 wifi: mac80211: do not abuse fq.lock in ieee80211_do_stop() -- https://patchwork.kernel.org/project/linux-wireless/patch/9cc9b81d-75a3-3925-b612-9d0ad3cab82b@I-love.SAKURA.ne.jp/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists