netdev - Re: [PATCH net-next v3 1/3] devlink: introduce framework for selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jul 2022 15:48:05 +0530
From:   Vikas Gupta <vikas.gupta@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jiri Pirko <jiri@...dia.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>, dsahern@...nel.org,
        stephen@...workplumber.org, Eric Dumazet <edumazet@...gle.com>,
        pabeni@...hat.com, ast@...nel.org, leon@...nel.org,
        linux-doc@...r.kernel.org, corbet@....net,
        Michael Chan <michael.chan@...adcom.com>,
        Andrew Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next v3 1/3] devlink: introduce framework for selftests

Hi Jakub,

On Tue, Jul 19, 2022 at 9:03 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 18 Jul 2022 11:50:30 +0530 Vikas Gupta wrote:
> > +     for (i = 1; i < DEVLINK_SELFTEST_ATTR_MAX + 1; i++) {
> > +             u8 res;
> > +
> > +             if (nla_get_flag(tb[i])) {
> > +                     res = devlink->ops->selftest_run(devlink, i,
>
> Shouldn't we selftest_check() first to make sure the driver supports
> given test?
 Yes, I`ll add selftest_check() here rather than letting the driver return SKIP.

Thanks,
Vikas

>
> > +     [DEVLINK_ATTR_SELFTESTS_INFO] = { .type = NLA_NESTED },
>
>         ... = NLA_POLICY_NESTED(devlink_selftest_nl_policy),

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4206 bytes)