lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <165822781506.1764.166272738384218919.git-patchwork-notify@kernel.org> Date: Tue, 19 Jul 2022 10:50:15 +0000 From: patchwork-bot+netdevbpf@...nel.org To: Taehee Yoo <ap420073@...il.com> Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org Subject: Re: [PATCH net v2 0/8] amt: fix validation and synchronization bugs Hello: This series was applied to netdev/net.git (master) by Paolo Abeni <pabeni@...hat.com>: On Sun, 17 Jul 2022 16:09:02 +0000 you wrote: > There are some synchronization issues in the amt module. > Especially, an amt gateway doesn't well synchronize its own variables > and status(amt->status). > It tries to use a workqueue for handles in a single thread. > A global lock is also good, but it would occur complex locking complex. > > In this patchset, only the gateway uses workqueue. > The reason why only gateway interface uses workqueue is that gateway > should manage its own states and variables a little bit statefully. > But relay doesn't need to manage tunnels statefully, stateless is okay. > So, relay side message handlers are okay to be called concurrently. > But it doesn't mean that no lock is needed. > > [...] Here is the summary with links: - [net,v2,1/8] amt: use workqueue for gateway side message handling https://git.kernel.org/netdev/net/c/30e22a6ebca0 - [net,v2,2/8] amt: remove unnecessary locks https://git.kernel.org/netdev/net/c/9c343ea6185f - [net,v2,3/8] amt: use READ_ONCE() in amt module https://git.kernel.org/netdev/net/c/928f353cb867 - [net,v2,4/8] amt: add missing regeneration nonce logic in request logic https://git.kernel.org/netdev/net/c/627f16931bf3 - [net,v2,5/8] amt: drop unexpected advertisement message https://git.kernel.org/netdev/net/c/40185f359fba - [net,v2,6/8] amt: drop unexpected query message https://git.kernel.org/netdev/net/c/239d886601e3 - [net,v2,7/8] amt: drop unexpected multicast data https://git.kernel.org/netdev/net/c/e882827d5b89 - [net,v2,8/8] amt: do not use amt->nr_tunnels outside of lock https://git.kernel.org/netdev/net/c/989918482bbc You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists