netdev - Re: [net-next PATCH v2 15/15] net: dsa: qca8k: drop unnecessary exposed function and make them static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62d6b319.1c69fb81.6be76.d6b1@mx.google.com>
Date:   Tue, 19 Jul 2022 15:35:18 +0200
From:   Christian Marangi <ansuelsmth@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [net-next PATCH v2 15/15] net: dsa: qca8k: drop unnecessary
 exposed function and make them static

On Tue, Jul 19, 2022 at 04:29:31PM +0300, Vladimir Oltean wrote:
> On Tue, Jul 19, 2022 at 02:57:26AM +0200, Christian Marangi wrote:
> > Some function were exposed to permit migration to common code. Drop them
> > and make them static now that the user are in the same common code.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > ---
> 
> Hmm, ideally the last patch that removes a certain function from being
> called from qca8k-8xxx.c would also delete its prototype and make it
> static in qca8k-common.c. Would that be hard to change?

Can be done, it's really to compile check the changes and fix them.
Problem is that the patch number would explode. (ok explode is a big
thing but i think that would add 2-3 more patch to this big series...
this is why I did the static change as the last patch instead of in the
middle of the series)

But yes it's totally doable and not that hard honestly.

-- 
	Ansuel