lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c66afab7-732c-c68e-cc53-7425d92df42b@gmail.com> Date: Tue, 19 Jul 2022 12:03:42 -0600 From: David Ahern <dsahern@...il.com> To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, petrm@...dia.com, amcohen@...dia.com, nicolas.dichtel@...nd.com, mlxsw@...dia.com, stable@...r.kernel.org Subject: Re: [PATCH net] mlxsw: spectrum_router: Fix IPv4 nexthop gateway indication On 7/19/22 6:26 AM, Ido Schimmel wrote: > mlxsw needs to distinguish nexthops with a gateway from connected > nexthops in order to write the former to the adjacency table of the > device. The check used to rely on the fact that nexthops with a gateway > have a 'link' scope whereas connected nexthops have a 'host' scope. This > is no longer correct after commit 747c14307214 ("ip: fix dflt addr > selection for connected nexthop"). > > Fix that by instead checking the address family of the gateway IP. This > is a more direct way and also consistent with the IPv6 counterpart in > mlxsw_sp_rt6_is_gateway(). > > Cc: stable@...r.kernel.org > Fixes: 747c14307214 ("ip: fix dflt addr selection for connected nexthop") > Fixes: 597cfe4fc339 ("nexthop: Add support for IPv4 nexthops") > Signed-off-by: Ido Schimmel <idosch@...dia.com> > Reviewed-by: Amit Cohen <amcohen@...dia.com> > --- > Copied stable since Nicolas' patch has stable copied and I don't want > stable trees to have his patch, but not mine. To make it clear how far > this patch needs to be backported, I have included the same Fixes tag as > him. > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern <dsahern@...nel.org>
Powered by blists - more mailing lists