netdev - Re: [PATCH net-next v4] net: virtio_net: notifications coalescing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJs=3_DghKfyFMNzxLkmM9g-yPkoWF2s5Y36g920J9=9j_LvmQ@mail.gmail.com>
Date:   Tue, 19 Jul 2022 10:18:45 +0300
From:   Alvaro Karsz <alvaro.karsz@...id-run.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     netdev <netdev@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v4] net: virtio_net: notifications coalescing support

> Yes but this "issue" exists before VIRTIO_NET_F_NOTF_COAL. It might be
> better to have an independent patch to fix.


Maybe I'm wrong, but I don't think that you could receive
tx_coalesce_usecs/rx_coalesce_usecs without this patch, since the
ethtool_ops struct without this patch is:

static const struct ethtool_ops virtnet_ethtool_ops = {
.supported_coalesce_params = ETHTOOL_COALESCE_MAX_FRAMES,
        .......

And with this patch is:
static const struct ethtool_ops virtnet_ethtool_ops = {
.supported_coalesce_params = ETHTOOL_COALESCE_MAX_FRAMES |
ETHTOOL_COALESCE_USECS,