lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220720234209.GP5049@ziepe.ca> Date: Wed, 20 Jul 2022 20:42:09 -0300 From: Jason Gunthorpe <jgg@...pe.ca> To: Long Li <longli@...rosoft.com> Cc: Dexuan Cui <decui@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Stephen Hemminger <sthemmin@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Leon Romanovsky <leon@...nel.org>, "edumazet@...gle.com" <edumazet@...gle.com>, "shiraz.saleem@...el.com" <shiraz.saleem@...el.com>, Ajay Sharma <sharmaajay@...rosoft.com>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org> Subject: Re: [Patch v4 03/12] net: mana: Handle vport sharing between devices On Tue, Jul 12, 2022 at 06:48:09PM +0000, Long Li wrote: > > > @@ -563,9 +581,19 @@ static int mana_cfg_vport(struct > > > mana_port_context *apc, u32 protection_dom_id, > > > > > > apc->tx_shortform_allowed = resp.short_form_allowed; > > > apc->tx_vp_offset = resp.tx_vport_offset; > > > + > > > + netdev_info(apc->ndev, "Configured vPort %llu PD %u DB %u\n", > > > + apc->port_handle, protection_dom_id, doorbell_pg_id); > > Should this be netdev_dbg()? > > The log buffer can be flooded if there are many vPorts per VF PCI device and > > there are a lot of VFs. > > The reason netdev_info () is used is that this message is important > for troubleshooting initial setup issues with Ethernet driver. We > rely on user to get this configured right to share the same hardware > port between Ethernet and RDMA driver. As far as I know, there is no > easy way for a driver to "take over" an exclusive hardware resource > from another driver. This seems like a really strange statement. Exactly how does all of this work? Jason
Powered by blists - more mailing lists