netdev - Re: [PATCH net] Revert "tcp: change pingpong threshold to 3"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jul 2022 08:20:46 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Wei Wang <weiwan@...gle.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Yuchung Cheng <ycheng@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        LemmyHuang <hlm3280@....com>
Subject: Re: [PATCH net] Revert "tcp: change pingpong threshold to 3"

On Wed, Jul 20, 2022 at 7:32 PM Wei Wang <weiwan@...gle.com> wrote:
>
> This reverts commit 4a41f453bedfd5e9cd040bad509d9da49feb3e2c.
>
> This to-be-reverted commit was meant to apply a stricter rule for the
> stack to enter pingpong mode. However, the condition used to check for
> interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
> jiffy based and might be too coarse, which delays the stack entering
> pingpong mode.
> We revert this patch so that we no longer use the above condition to
> determine interactive session, and also reduce pingpong threshold to 1.
>
> Reported-by: LemmyHuang <hlm3280@....com>
> Suggested-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> ---

Thanks, Wei. The substance of the change looks good to me. I would
suggest adding a Fixes: tag as the first footer in the commit message
to make sure this gets backported to the appropriate stable branches.
Otherwise this looks great.

Thanks!
neal