netdev - Re: [PATCH net-next] net: ipa: fix build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5a1c541c-3b61-a838-1502-5224d4b8d0a4@ieee.org>
Date:   Thu, 21 Jul 2022 09:15:42 -0500
From:   Alex Elder <elder@...e.org>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     Alex Elder <elder@...nel.org>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] net: ipa: fix build

On 7/21/22 8:55 AM, Paolo Abeni wrote:
> After commit 2c7b9b936bdc ("net: ipa: move configuration data files
> into a subdirectory"), build of the ipa driver fails with the
> following error:
> 
> drivers/net/ipa/data/ipa_data-v3.1.c:9:10: fatal error: gsi.h: No such file or directory
> 
> After the mentioned commit, all the file included by the configuration
> are in the parent directory. Fix the issue updating the include path.
> 
> Fixes: 2c7b9b936bdc ("net: ipa: move configuration data files into a subdirectory")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Interesting...  This didn't happen for me.

Can you tell me more about your particular build environment
so I can try to reproduce it?  I haven't tested your fix yet
in my environment.

					-Alex

> ---
> Note: I could not use CFLAGS_* here, due to the relevant compilation
> unit name including a slash. Any better option more than welcome!
> ---
>   drivers/net/ipa/data/ipa_data-v3.1.c   | 8 ++++----
>   drivers/net/ipa/data/ipa_data-v3.5.1.c | 8 ++++----
>   drivers/net/ipa/data/ipa_data-v4.11.c  | 8 ++++----
>   drivers/net/ipa/data/ipa_data-v4.2.c   | 8 ++++----
>   drivers/net/ipa/data/ipa_data-v4.5.c   | 8 ++++----
>   drivers/net/ipa/data/ipa_data-v4.9.c   | 8 ++++----
>   6 files changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/ipa/data/ipa_data-v3.1.c b/drivers/net/ipa/data/ipa_data-v3.1.c
> index 00f4e506e6e5..1c1895aea811 100644
> --- a/drivers/net/ipa/data/ipa_data-v3.1.c
> +++ b/drivers/net/ipa/data/ipa_data-v3.1.c
> @@ -6,10 +6,10 @@
>   
>   #include <linux/log2.h>
>   
> -#include "gsi.h"
> -#include "ipa_data.h"
> -#include "ipa_endpoint.h"
> -#include "ipa_mem.h"
> +#include "../gsi.h"
> +#include "../ipa_data.h"
> +#include "../ipa_endpoint.h"
> +#include "../ipa_mem.h"
>   
>   /** enum ipa_resource_type - IPA resource types for an SoC having IPA v3.1 */
>   enum ipa_resource_type {
> diff --git a/drivers/net/ipa/data/ipa_data-v3.5.1.c b/drivers/net/ipa/data/ipa_data-v3.5.1.c
> index b7e32e87733e..58b708d2fc75 100644
> --- a/drivers/net/ipa/data/ipa_data-v3.5.1.c
> +++ b/drivers/net/ipa/data/ipa_data-v3.5.1.c
> @@ -6,10 +6,10 @@
>   
>   #include <linux/log2.h>
>   
> -#include "gsi.h"
> -#include "ipa_data.h"
> -#include "ipa_endpoint.h"
> -#include "ipa_mem.h"
> +#include "../gsi.h"
> +#include "../ipa_data.h"
> +#include "../ipa_endpoint.h"
> +#include "../ipa_mem.h"
>   
>   /** enum ipa_resource_type - IPA resource types for an SoC having IPA v3.5.1 */
>   enum ipa_resource_type {
> diff --git a/drivers/net/ipa/data/ipa_data-v4.11.c b/drivers/net/ipa/data/ipa_data-v4.11.c
> index 1be823e5c5c2..a204e439c23d 100644
> --- a/drivers/net/ipa/data/ipa_data-v4.11.c
> +++ b/drivers/net/ipa/data/ipa_data-v4.11.c
> @@ -4,10 +4,10 @@
>   
>   #include <linux/log2.h>
>   
> -#include "gsi.h"
> -#include "ipa_data.h"
> -#include "ipa_endpoint.h"
> -#include "ipa_mem.h"
> +#include "../gsi.h"
> +#include "../ipa_data.h"
> +#include "../ipa_endpoint.h"
> +#include "../ipa_mem.h"
>   
>   /** enum ipa_resource_type - IPA resource types for an SoC having IPA v4.11 */
>   enum ipa_resource_type {
> diff --git a/drivers/net/ipa/data/ipa_data-v4.2.c b/drivers/net/ipa/data/ipa_data-v4.2.c
> index 683f1f91042f..04f574fe006f 100644
> --- a/drivers/net/ipa/data/ipa_data-v4.2.c
> +++ b/drivers/net/ipa/data/ipa_data-v4.2.c
> @@ -4,10 +4,10 @@
>   
>   #include <linux/log2.h>
>   
> -#include "gsi.h"
> -#include "ipa_data.h"
> -#include "ipa_endpoint.h"
> -#include "ipa_mem.h"
> +#include "../gsi.h"
> +#include "../ipa_data.h"
> +#include "../ipa_endpoint.h"
> +#include "../ipa_mem.h"
>   
>   /** enum ipa_resource_type - IPA resource types for an SoC having IPA v4.2 */
>   enum ipa_resource_type {
> diff --git a/drivers/net/ipa/data/ipa_data-v4.5.c b/drivers/net/ipa/data/ipa_data-v4.5.c
> index 79398f286a9c..684239e71f46 100644
> --- a/drivers/net/ipa/data/ipa_data-v4.5.c
> +++ b/drivers/net/ipa/data/ipa_data-v4.5.c
> @@ -4,10 +4,10 @@
>   
>   #include <linux/log2.h>
>   
> -#include "gsi.h"
> -#include "ipa_data.h"
> -#include "ipa_endpoint.h"
> -#include "ipa_mem.h"
> +#include "../gsi.h"
> +#include "../ipa_data.h"
> +#include "../ipa_endpoint.h"
> +#include "../ipa_mem.h"
>   
>   /** enum ipa_resource_type - IPA resource types for an SoC having IPA v4.5 */
>   enum ipa_resource_type {
> diff --git a/drivers/net/ipa/data/ipa_data-v4.9.c b/drivers/net/ipa/data/ipa_data-v4.9.c
> index 4b96efd05cf2..2333e15f9533 100644
> --- a/drivers/net/ipa/data/ipa_data-v4.9.c
> +++ b/drivers/net/ipa/data/ipa_data-v4.9.c
> @@ -4,10 +4,10 @@
>   
>   #include <linux/log2.h>
>   
> -#include "gsi.h"
> -#include "ipa_data.h"
> -#include "ipa_endpoint.h"
> -#include "ipa_mem.h"
> +#include "../gsi.h"
> +#include "../ipa_data.h"
> +#include "../ipa_endpoint.h"
> +#include "../ipa_mem.h"
>   
>   /** enum ipa_resource_type - IPA resource types for an SoC having IPA v4.9 */
>   enum ipa_resource_type {