netdev - Re: [PATCH net-next v3 20/47] net: fman: Store initialization function in match data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d490504-c03d-f418-cec2-c976831a224f@seco.com>
Date:   Thu, 21 Jul 2022 11:34:05 -0400
From:   Sean Anderson <sean.anderson@...o.com>
To:     Camelia Alexandra Groza <camelia.groza@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Madalin Bucur <madalin.bucur@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Russell King <linux@...linux.org.uk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 20/47] net: fman: Store initialization
 function in match data



On 7/21/22 8:51 AM, Camelia Alexandra Groza wrote:
>> -----Original Message-----
>> From: Sean Anderson <sean.anderson@...o.com>
>> Sent: Saturday, July 16, 2022 0:59
>> To: David S . Miller <davem@...emloft.net>; Jakub Kicinski
>> <kuba@...nel.org>; Madalin Bucur <madalin.bucur@....com>;
>> netdev@...r.kernel.org
>> Cc: Paolo Abeni <pabeni@...hat.com>; Eric Dumazet
>> <edumazet@...gle.com>; linux-arm-kernel@...ts.infradead.org; Russell
>> King <linux@...linux.org.uk>; linux-kernel@...r.kernel.org; Sean Anderson
>> <sean.anderson@...o.com>
>> Subject: [PATCH net-next v3 20/47] net: fman: Store initialization function in
>> match data
>> 
>> Instead of re-matching the compatible string in order to determine the
>> init function, just store it in the match data. This also move the setting
>> of the rest of the functions into init as well. 
> 
> This last sentence can be rephrased to be clearer. Maybe something like:
> The separate setup functions aren't needed anymore. Merge their content
> into init as well.

You're right, this is not really clear. I will revise the wording.

--Sean

>> To ensure everything
>> compiles correctly, we move them to the bottom of the file.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@...o.com>
> 
> Acked-by: Camelia Groza <camelia.groza@....com>
>