netdev - Re: [PATCH net-next 1/2] tls: rx: release the sock lock on locking timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL7mkgn3NuEvdneJUc0=+NQUMG505tTCdcxwnBFY_a6ag@mail.gmail.com>
Date:   Thu, 21 Jul 2022 19:58:16 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>, Paolo Abeni <pabeni@...hat.com>,
        Boris Pismenny <borisp@...dia.com>,
        John Fastabend <john.fastabend@...il.com>,
        Maxim Mikityanskiy <maximmi@...dia.com>,
        Tariq Toukan <tariqt@...dia.com>, vfedorenko@...ek.ru,
        syzbot+16e72110feb2b653ef27@...kaller.appspotmail.com
Subject: Re: [PATCH net-next 1/2] tls: rx: release the sock lock on locking timeout

On Wed, Jul 20, 2022 at 10:37 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Eric reports we should release the socket lock if the entire
> "grab reader lock" operation has failed. The callers assume
> they don't have to release it or otherwise unwind.
>
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot+16e72110feb2b653ef27@...kaller.appspotmail.com
> Fixes: 4cbc325ed6b4 ("tls: rx: allow only one reader at a time")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  net/tls/tls_sw.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)

Reviewed-by: Eric Dumazet <edumazet@...gle.com>