netdev - Re: [PATCH net-next] mlxsw: fix devlink use after frees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ytpvo24UKH8b0KXG@shredder>
Date:   Fri, 22 Jul 2022 12:36:35 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Jiri Pirko <jiri@...dia.com>, Petr Machata <petrm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] mlxsw: fix devlink use after frees

On Fri, Jul 22, 2022 at 09:32:40AM +0300, Dan Carpenter wrote:
> Unlock "devlink" before freeing it instead of after.
> 
> Fixes: 72a4c8c94efa ("mlxsw: convert driver to use unlocked devlink API during init/fini")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks for the patch, but a fix was already posted yesterday:

https://patchwork.kernel.org/project/netdevbpf/patch/20220721142424.3975704-1-jiri@resnulli.us/