netdev - Re: [PATCH v2 2/3] net: macb: Sort CAPS flags by bit positions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac8728f9-1fec-7307-9468-84804db28505@microchip.com>
Date:   Fri, 22 Jul 2022 11:10:58 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <harini.katakam@...inx.com>, <Nicolas.Ferre@...rochip.com>,
        <davem@...emloft.net>, <kuba@...nel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <michal.simek@...inx.com>, <harinikatakamlinux@...il.com>,
        <harini.katakam@....com>, <devicetree@...r.kernel.org>,
        <radhey.shyam.pandey@...inx.com>
Subject: Re: [PATCH v2 2/3] net: macb: Sort CAPS flags by bit positions

On 22.07.2022 14:03, Harini Katakam wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Sort capability flags by the bit position set.
> 
> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
> v2:
> New patch to sort existing CAPS flags' bit order.
> 
>  drivers/net/ethernet/cadence/macb.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index 7ca077b65eaa..583e860fdca8 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -717,14 +717,14 @@
>  #define MACB_CAPS_BD_RD_PREFETCH               0x00000080
>  #define MACB_CAPS_NEEDS_RSTONUBR               0x00000100
>  #define MACB_CAPS_MIIONRGMII                   0x00000200
> +#define MACB_CAPS_PCS                          0x01000000
> +#define MACB_CAPS_HIGH_SPEED                   0x02000000
>  #define MACB_CAPS_CLK_HW_CHG                   0x04000000
>  #define MACB_CAPS_MACB_IS_EMAC                 0x08000000
>  #define MACB_CAPS_FIFO_MODE                    0x10000000
>  #define MACB_CAPS_GIGABIT_MODE_AVAILABLE       0x20000000
>  #define MACB_CAPS_SG_DISABLED                  0x40000000
>  #define MACB_CAPS_MACB_IS_GEM                  0x80000000
> -#define MACB_CAPS_PCS                          0x01000000
> -#define MACB_CAPS_HIGH_SPEED                   0x02000000
> 
>  /* LSO settings */
>  #define MACB_LSO_UFO_ENABLE                    0x01
> --
> 2.17.1
>