netdev - Re: [PATCH net-next] net: ipa: fix build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a23bd6b6-2244-1e58-20d1-5713d304acfd@ieee.org>
Date:   Fri, 22 Jul 2022 08:12:03 -0500
From:   Alex Elder <elder@...e.org>
To:     Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Alex Elder <elder@...nel.org>
Subject: Re: [PATCH net-next] net: ipa: fix build

On 7/21/22 11:41 AM, Jakub Kicinski wrote:
> On Thu, 21 Jul 2022 16:50:20 +0200 Paolo Abeni wrote:
>>> Interesting...  This didn't happen for me.
>>>
>>>
>>> Can you tell me more about your particular build environment
>>> so I can try to reproduce it?  I haven't tested your fix yet
>>> in my environment.
>>
>> Possibly ENOCOFFEE here, but on net-next@...200e8491b,
>>
>> make clean; make allmodconfig; make
>>
>> fails reproducibly here, with gcc 11.3.1, make 4.3.
>>
>> Do you have by chance uncommited local changes?
> 
> Oh, poops. You're right. I think all - the build bots, Alex and I
> build with O=builddir, in which case the build works. I'll let the
> build bot catch up to your fix and apply it. Sorry about that!

I'm glad you know this, I was just about to start figuring
out what the difference was:
- gcc vs clang
- module vs built-in
- x86 vs aarch64
And I didn't even think about "O=<builddir>"...

Is this the right fix?  It's A-OK with me if it is.

(I'm about to try to reproduce it now without "O="...)

Thank you.

					-Alex