netdev - RE: [PATCH net-next] r8169: add support for rtl8168h(revid 0x2a) + rtl8211fs fiber application

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7f31872f7e54970b99b5a3df94cb1f1@realtek.com>
Date:   Fri, 22 Jul 2022 15:22:49 +0000
From:   Hau <hau@...ltek.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] r8169: add support for rtl8168h(revid 0x2a) + rtl8211fs fiber application

> On Thu, 21 Jul 2022 22:45:50 +0800 Chunhao Lin wrote:
> > rtl8168h(revid 0x2a) + rtl8211fs is for fiber related application.
> > rtl8168h will control rtl8211fs via its eeprom or gpo pins.
> > Fiber module will be connected to rtl8211fs. The link speed between
> > rtl8168h and rtl8211fs is decied by fiber module.
> 
> Compiler says:
> 
> drivers/net/ethernet/realtek/r8169_main.c:614:24: warning: symbol
> 'rtl_sfp_if_eeprom_mask' was not declared. Should it be static?
> drivers/net/ethernet/realtek/r8169_main.c:617:24: warning: symbol
> 'rtl_sfp_if_gpo_mask' was not declared. Should it be static?
> 

I will change code to use static my next patch.

 ------Please consider the environment before printing this e-mail.