netdev - Re: [PATCH] net: rose: fix unregistered netdevice: waiting for rose0 to become free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c033c36-c291-1927-079b-b4aee5f7ac08@free.fr>
Date:   Fri, 22 Jul 2022 18:41:28 +0200
From:   Bernard f6bvp <f6bvp@...e.fr>
To:     kuba@...nel.org
Cc:     davem@...emloft.net, duoming@....edu.cn, edumazet@...gle.com,
        f6bvp@...e.fr, linux-hams@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        pabeni@...hat.com, ralf@...ux-mips.org
Subject: Re: [PATCH] net: rose: fix unregistered netdevice: waiting for rose0
 to become free

Here is the context.

This patch adds dev_put(dev) in order to allow removal of rose module
after use of AX25 and ROSE via rose0 device.

Otherwise when trying to remove rose module via rmmod rose an infinite
loop message was displayed on all consoles with xx being a random number.

unregistered_netdevice: waiting for rose0 to become free. Usage count = xx

unregistered_netdevice: waiting for rose0 to become free. Usage count = xx

...

With the patch it is ok to rmmod rose.

This bug appeared with kernel 4.10 and has been only partially repaired 
by adding two dev_put(dev).

Signed-off-by: Bernard Pidoux <f6bvp@...e.fr>

---
  net/rose/af_rose.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c
index bf2d986a6bc3..4163171ce3a6 100644
--- a/net/rose/af_rose.c
+++ b/net/rose/af_rose.c
@@ -711,6 +711,8 @@ static int rose_bind(struct socket *sock, struct 
sockaddr *uaddr, int addr_len)
      rose_insert_socket(sk);

      sock_reset_flag(sk, SOCK_ZAPPED);
+
+    dev_put(dev);

      return 0;
  }
-- 
2.34.1

[master da21d19e920d] [PATCH] net: rose: fix unregistered netdevice: 
waiting for rose0 to become free
  Date: Mon Jul 18 16:23:54 2022 +0200
  1 file changed, 2 insertions(+)