netdev - Re: [PATCH net-next] net/sched: act_mirred: avoid printout in the traffic path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220722150816.08349bed@kernel.org>
Date:   Fri, 22 Jul 2022 15:08:16 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: act_mirred: avoid printout in the
 traffic path

On Thu, 21 Jul 2022 18:19:22 +0200 Davide Caratti wrote:
>  			if (tcf_mirred_dev_dereference(m) == dev) {
> +				pr_notice("tc mirred: target device %s is %s\n",
> +					  dev->name,
> +					  event == NETDEV_UNREGISTER ? "gone" : "down");

Should we only do this print only once per event as well?
There can be a large number of actions redirecting to a single device,
no point printing the warning multiple times for one down event.