netdev - Re: [PATCH net-next] r8169: add support for rtl8168h(revid 0x2a) + rtl8211fs fiber application

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220721184243.31ace75f@kicinski-fedora-PC1C0HJN>
Date:   Thu, 21 Jul 2022 18:42:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Chunhao Lin <hau@...ltek.com>
Cc:     <netdev@...r.kernel.org>, <nic_swsd@...ltek.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: add support for rtl8168h(revid 0x2a) +
 rtl8211fs fiber application

On Thu, 21 Jul 2022 22:45:50 +0800 Chunhao Lin wrote:
> rtl8168h(revid 0x2a) + rtl8211fs is for fiber related application.
> rtl8168h will control rtl8211fs via its eeprom or gpo pins.
> Fiber module will be connected to rtl8211fs. The link speed between
> rtl8168h and rtl8211fs is decied by fiber module.

Compiler says:

drivers/net/ethernet/realtek/r8169_main.c:614:24: warning: symbol 'rtl_sfp_if_eeprom_mask' was not declared. Should it be static?
drivers/net/ethernet/realtek/r8169_main.c:617:24: warning: symbol 'rtl_sfp_if_gpo_mask' was not declared. Should it be static?