netdev - Re: [PATCH net v2] Revert "tcp: change pingpong threshold to 3"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKjee+1CEHbBPWTUw=ndW_0HtxQo_duMj9K0Dr11pcm+A@mail.gmail.com>
Date:   Fri, 22 Jul 2022 11:12:49 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     Wei Wang <weiwan@...gle.com>, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>, LemmyHuang <hlm3280@....com>
Subject: Re: [PATCH net v2] Revert "tcp: change pingpong threshold to 3"

On Thu, Jul 21, 2022 at 10:56 PM Neal Cardwell <ncardwell@...gle.com> wrote:
>
> On Thu, Jul 21, 2022 at 4:44 PM Wei Wang <weiwan@...gle.com> wrote:
> >
> > This reverts commit 4a41f453bedfd5e9cd040bad509d9da49feb3e2c.
> >
> > This to-be-reverted commit was meant to apply a stricter rule for the
> > stack to enter pingpong mode. However, the condition used to check for
> > interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
> > jiffy based and might be too coarse, which delays the stack entering
> > pingpong mode.
> > We revert this patch so that we no longer use the above condition to
> > determine interactive session, and also reduce pingpong threshold to 1.
> >
> > Fixes: 4a41f453bedf ("tcp: change pingpong threshold to 3")
> > Reported-by: LemmyHuang <hlm3280@....com>
> > Suggested-by: Neal Cardwell <ncardwell@...gle.com>
> > Signed-off-by: Wei Wang <weiwan@...gle.com>
> >
> > ---
> > v2: added Fixes tag
>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>
>
> Looks great to me. Thanks, Wei!

Reviewed-by: Eric Dumazet <edumazet@...gle.com>