netdev - Re: [PATCH net-next 10/15] mlxsw: spectrum_ptp: Initialize the clock to zero as part of initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yt3EQz+OCZDadjAe@hoboy.vegasvil.org>
Date:   Sun, 24 Jul 2022 15:14:27 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Ido Schimmel <idosch@...dia.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, petrm@...dia.com,
        amcohen@...dia.com, danieller@...dia.com, mlxsw@...dia.com
Subject: Re: [PATCH net-next 10/15] mlxsw: spectrum_ptp: Initialize the clock
 to zero as part of initialization

On Sun, Jul 24, 2022 at 11:03:24AM +0300, Ido Schimmel wrote:
> From: Amit Cohen <amcohen@...dia.com>
> 
> As lately recommended in the mailing list[1], set the clock to zero time as
> part of initialization.
> 
> The idea is that when the clock reads 'Jan 1, 1970', then it is clearly
> wrong and user will not mistakenly think that the clock is set correctly.
> If as part of initialization, the driver sets the clock, user might see
> correct date and time (maybe with a small shift) and assume that there
> is no need to sync the clock.
> 
> Fix the existing code of Spectrum-1 to set the 'timecounter' to zero.

Acked-by: Richard Cochran <richardcochran@...il.com>