netdev - Re: [PATCH] wifi: wil6210: debugfs: fix uninitialized variable use in `wil_write_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220725063410.GO2316@kadam>
Date:   Mon, 25 Jul 2022 09:34:10 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ammar Faizi <ammarfaizi2@...weeb.org>
Cc:     Kalle Valo <kvalo@...nel.org>, Kalle Valo <quic_kvalo@...cinc.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Linux Wireless Mailing List <linux-wireless@...r.kernel.org>,
        netdev Mailing List <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] wifi: wil6210: debugfs: fix uninitialized variable use
 in `wil_write_file_wmi()`

On Mon, Jul 25, 2022 at 03:26:18AM +0700, Ammar Faizi wrote:
> Commit 7a4836560a61 changes simple_write_to_buffer() with memdup_user()
> but it forgets to change the value to be returned that came from
> simple_write_to_buffer() call. It results in the following warning:
> 
>   warning: variable 'rc' is uninitialized when used here [-Wuninitialized]
>            return rc;
>                   ^~
> 
> Remove rc variable and just return the passed in length if the
> memdup_user() succeeds.
> 
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 7a4836560a6198d245d5732e26f94898b12eb760 ("wifi: wil6210: debugfs: fix info leak in wil_write_file_wmi()")
> Fixes: ff974e4083341383d3dd4079e52ed30f57f376f0 ("wil6210: debugfs interface to send raw WMI command")
> Signed-off-by: Ammar Faizi <ammarfaizi2@...weeb.org>

Oops.  Sorry!

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter