netdev - Re: [RFC PATCH net-next v6 1/4] flow_dissector: Add PPPoE dissectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220725155948.GA18808@pc-4.home>
Date:   Mon, 25 Jul 2022 17:59:48 +0200
From:   Guillaume Nault <gnault@...hat.com>
To:     Marcin Szycik <marcin.szycik@...ux.intel.com>
Cc:     netdev@...r.kernel.org, anthony.l.nguyen@...el.com,
        davem@...emloft.net, xiyou.wangcong@...il.com,
        jesse.brandeburg@...el.com, gustavoars@...nel.org,
        baowen.zheng@...igine.com, boris.sukholitko@...adcom.com,
        edumazet@...gle.com, kuba@...nel.org, jhs@...atatu.com,
        jiri@...nulli.us, kurt@...utronix.de, pablo@...filter.org,
        pabeni@...hat.com, paulb@...dia.com, simon.horman@...igine.com,
        komachi.yoshiki@...il.com, zhangkaiheb@....com,
        intel-wired-lan@...ts.osuosl.org,
        michal.swiatkowski@...ux.intel.com, wojciech.drewek@...el.com,
        alexandr.lobakin@...el.com, mostrows@...akeasy.net,
        paulus@...ba.org
Subject: Re: [RFC PATCH net-next v6 1/4] flow_dissector: Add PPPoE dissectors

On Mon, Jul 18, 2022 at 02:18:10PM +0200, Marcin Szycik wrote:
> From: Wojciech Drewek <wojciech.drewek@...el.com>
> 
> Allow to dissect PPPoE specific fields which are:
> - session ID (16 bits)
> - ppp protocol (16 bits)
> - type (16 bits) - this is PPPoE ethertype, for now only
>   ETH_P_PPP_SES is supported, possible ETH_P_PPP_DISC
>   in the future
> 
> The goal is to make the following TC command possible:
> 
>   # tc filter add dev ens6f0 ingress prio 1 protocol ppp_ses \
>       flower \
>         pppoe_sid 12 \
>         ppp_proto ip \
>       action drop
> 
> Note that only PPPoE Session is supported.

Acked-by: Guillaume Nault <gnault@...hat.com>