netdev - Re: [PATCH net-next] ip6mr: remove stray rcu_read_unlock() from ip6_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220725203630.6dtoemizkcsri355@skbuf>
Date:   Mon, 25 Jul 2022 23:36:30 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] ip6mr: remove stray rcu_read_unlock() from
 ip6_mr_forward()

On Mon, Jul 25, 2022 at 01:05:54PM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> One rcu_read_unlock() should have been removed in blamed commit.
> 
> Fixes: 9b1c21d898fd ("ip6mr: do not acquire mrt_lock while calling ip6_mr_forward()")
> Reported-by: Vladimir Oltean <olteanv@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>