lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Jul 2022 21:19:44 +0000 From: "Keller, Jacob E" <jacob.e.keller@...el.com> To: Stephen Hemminger <stephen@...workplumber.org> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jonathan Corbet <corbet@....net>, Jiri Pirko <jiri@...dia.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, David Ahern <dsahern@...nel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org> Subject: RE: [iproute2-next v3 3/3] devlink: add dry run attribute support to devlink flash > -----Original Message----- > From: Stephen Hemminger <stephen@...workplumber.org> > Sent: Monday, July 25, 2022 2:13 PM > To: Keller, Jacob E <jacob.e.keller@...el.com> > Cc: netdev@...r.kernel.org; Jonathan Corbet <corbet@....net>; Jiri Pirko > <jiri@...dia.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet > <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni > <pabeni@...hat.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; > David Ahern <dsahern@...nel.org>; linux-doc@...r.kernel.org > Subject: Re: [iproute2-next v3 3/3] devlink: add dry run attribute support to > devlink flash > > On Mon, 25 Jul 2022 13:56:50 -0700 > Jacob Keller <jacob.e.keller@...el.com> wrote: > > > To avoid potential issues, only allow the attribute to be added to > > commands when the kernel recognizes it. This is important because some > > commands do not perform strict validation. If we were to add the > > attribute without this check, an old kernel may silently accept the > > command and perform an update even when dry_run was requested. > > Sigh. Looks like the old kernels are buggy. The workaround in userspace > is also likely to be source of bugs. We've known about this problem for a while.. I think its more complicated than just switching to strict validation, since ideally we want to validate attributes for each command separately, and not just accepting all known attributes for a given command. Thanks, Jake
Powered by blists - more mailing lists