netdev - Re: [PATCH net v2] net: mld: fix reference count leak in mld_{query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165874921340.25231.17481959950698631240.git-patchwork-notify@kernel.org>
Date:   Mon, 25 Jul 2022 11:40:13 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Taehee Yoo <ap420073@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        netdev@...r.kernel.org, liuhangbin@...il.com
Subject: Re: [PATCH net v2] net: mld: fix reference count leak in mld_{query |
 report}_work()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Fri, 22 Jul 2022 17:06:35 +0000 you wrote:
> mld_{query | report}_work() processes queued events.
> If there are too many events in the queue, it re-queue a work.
> And then, it returns without in6_dev_put().
> But if queuing is failed, it should call in6_dev_put(), but it doesn't.
> So, a reference count leak would occur.
> 
> THREAD0				THREAD1
> mld_report_work()
> 				spin_lock_bh()
> 				if (!mod_delayed_work())
> 					in6_dev_hold();
> 				spin_unlock_bh()
> 	spin_lock_bh()
> 	schedule_delayed_work()
> 	spin_unlock_bh()
> 
> [...]

Here is the summary with links:
  - [net,v2] net: mld: fix reference count leak in mld_{query | report}_work()
    https://git.kernel.org/netdev/net/c/3e7d18b9dca3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html