netdev - Re: [PATCH 2/2 net-next] geneve: fix TOS inheriting for ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Jul 2022 18:29:56 +0200
From:   Matthias May <matthias.may@...termo.com>
To:     Guillaume Nault <gnault@...hat.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        <yoshfuji@...ux-ipv6.org>, <dsahern@...nel.org>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <nicolas.dichtel@...nd.com>, <eyal.birger@...il.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2 net-next] geneve: fix TOS inheriting for ipv6

On 25/07/2022 19:05, Guillaume Nault wrote:
> On Sun, Jul 24, 2022 at 02:37:41AM +0200, Matthias May wrote:
>> The current code uses the RT_TOS macro to cut off the 6 DSCP
>> bits, down to the original 3 TOS bits.
>>
>> Do not use this macro to get the prio for inheriting purposes.
> 
> Honestly, this patch is a bug fix and is suitable for the net tree
> (with appropriate 'Fixes' tag).
> 
> Ideally, we'd also fix ip6_dst_lookup_tunnel() (used by bareudp
> tunnels) and vxlan6_get_route().
> 
> Also, mlx5e_tc_tun_update_header_ipv6() and
> mlx5e_tc_tun_create_header_ipv6() both call RT_TOS() inside
> ip6_make_flowinfo() and certainly need to be fixed too.
> 

Hi Guillaume
How would i do that?
Send a v2 to net with the fixes tag on 95caf6f71a999?
Or just resend to net with the fixes tag on 95caf6f71a999?
Since there are no actual changes to the patch.
This kind of contradicts the statement that IPv4 and IPv6 should behave the same.
--> v6 would be fixed, but v4 not.

BR
Matthias

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (237 bytes)