netdev - Re: [patch net-next RFC] net: dsa: move port_setup/teardown to be called outside devlink port registered area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220726165520.due75djbddyz4uc4@skbuf>
Date:   Tue, 26 Jul 2022 19:55:20 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com
Subject: Re: [patch net-next RFC] net: dsa: move port_setup/teardown to be
 called outside devlink port registered area

On Tue, Jul 26, 2022 at 06:13:11PM +0200, Jiri Pirko wrote:
> Here it is:

Thanks, this one does apply.

We have the same problem, except now it's with port->region_list
(region_create does list_add_tail, port_register does INIT_LIST_HEAD).

I don't think you need to see this anymore, but anyway, here it is.

[    4.949727] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010
[    5.020395] CPU: 1 PID: 8 Comm: kworker/u4:0 Not tainted 5.19.0-rc7-07010-ga9b9500ffaac-dirty #3397
[    5.047447] pc : devlink_port_region_create+0x6c/0x150
[    5.052587] lr : dsa_devlink_port_region_create+0x64/0x90
[    5.057983] sp : ffff80000c17b8b0
[    5.132669] Call trace:
[    5.135109]  devlink_port_region_create+0x6c/0x150
[    5.139899]  dsa_devlink_port_region_create+0x64/0x90
[    5.144946]  mv88e6xxx_setup_devlink_regions_port+0x30/0x60
[    5.150520]  mv88e6xxx_port_setup+0x10/0x20
[    5.154700]  dsa_port_devlink_setup+0x60/0x150
[    5.159141]  dsa_register_switch+0x938/0x119c
[    5.163496]  mv88e6xxx_probe+0x714/0x770
[    5.167416]  mdio_probe+0x34/0x70